Refactor dotnet-desktop.yml for specific project setup#8
Merged
Conversation
Updated the workflow to use specific project names and removed unnecessary steps for unit testing and packaging.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GitHub Actions workflow for a .NET desktop application by streamlining it to focus only on basic build operations. The workflow is customized for the "StickerBomb" project and removes testing and packaging steps that were mentioned in the original template.
- Configures workflow for specific "StickerBomb.sln" solution
- Removes unit testing and packaging steps as mentioned in PR description
- Simplifies workflow to basic restore and artifact upload
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+84
to
+88
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: MSIX Package | ||
| path: ${{ env.Wap_Project_Directory }}\AppPackages |
There was a problem hiding this comment.
The workflow references ${{ env.Wap_Project_Directory }} environment variable which is never defined. This will cause the artifact upload step to fail as it's trying to upload from an undefined path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the workflow to use specific project names and removed unnecessary steps for unit testing and packaging.