feat(auth): redesign sign-in popups + modal in v3 design language#222
Merged
Conversation
The OAuth popup at /auth/popup.html broke at runtime because its inline script was refused by the site CSP (script-src 'self'), leaving users stuck on a blank "Completing sign-in…" screen. Extract the IIFE to a sibling popup.js, matching the desktop.html/desktop.js pattern that already exists. While both auth bridge pages were open, rebuild them around the v3 tokens (#0E0E10 stage, #1A1A1D chrome, Inter/SF Pro, 6px radii, brand pink #F92672) and the Splash visual vocabulary: large vcad. wordmark with brand-pink dot, indeterminate shimmer progress bar, primary CTA in brand pink. Drops Berkeley Mono since v3 reserves it for code. Same pass on AuthModal.tsx: - Wordmark text-3xl -> text-5xl to mirror Splash - Remove idle dot pulse, top edge gradient, backdrop blur - Opaque bg-surface, rounded-xl dialog, rounded-md controls - Lower buttons to h-10, tighten typography hierarchy - Replace Phosphor monochrome icons with the official 4-color Google G and a GitHub Octocat that uses currentColor so it tracks the theme - Autofocus the email field on open via onOpenAutoFocus (Radix's default focused the close button) Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/auth/popup.htmlwas hitting CSP because of an inline<script>block (script-src is'self', no'unsafe-inline'). Users got stuck on a blank "Completing sign-in…" screen. Extracted to a siblingpopup.js, matching the existingdesktop.html/desktop.jspattern.popup.html+desktop.html) and the in-appAuthModalto match the v3 design language from recent commits (02f9d8d1"comb out Borland-era UI patterns",ed32703b"adopt v3 design system tokens").Splash.tsx: largevcad.wordmark, brand-pink dot, indeterminate shimmer progress bar.Auth bridge pages (popup.html + desktop.html)
#0E0E10, chrome#1A1A1D, brand#F92672, 6px radii, opaque surfaces.popup.jsnow hides the progress bar once the success state is shown;desktop.jsdoes the same on fallback.AuthModal.tsx
text-3xl→text-5xl, mirrors Splash.bg-surfaceper v3 chrome.rounded-xlon the dialog,rounded-mdon buttons / input / error banner.h-11→h-10, tighter typography.tracking-[0.18em]+ 9.5px caps for plain lowercase 11px.text-text-tertdot separators.currentColorso it tracks the theme (white on dark, black on light).onOpenAutoFocusonDialog.Contentoverrides Radix's default (which focused the close button) and focuses the email field instead.Screenshots
Test plan
🤖 Generated with Claude Code