fix fsdp error from unused register token module - #2686
Open
Jubeku wants to merge 2 commits into
Open
Conversation
Collaborator
|
@shmh40 : can you have a look? |
clessig
reviewed
Jul 28, 2026
clessig
left a comment
Collaborator
There was a problem hiding this comment.
Can we also add this:
diff --git a/src/weathergen/model/model_interface.py b/src/weathergen/model/model_interface.py
index d67ceaed..9a52aede 100644
--- a/src/weathergen/model/model_interface.py
+++ b/src/weathergen/model/model_interface.py
@@ -94,7 +94,7 @@ def init_model_and_shard(
find_unused_parameters=cf.get("ddp_find_unused_parameters", True),
gradient_as_bucket_view=True,
bucket_cap_mb=512,
- static_graph=cf.get("ddp_static_graph", True),
+ static_graph=cf.get("ddp_static_graph", False),
)
elif with_ddp and with_fsdp:
It's related to the PR and causes silent degradation of model convergence. Potentially we should remove it at all as a config parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only create the auxiliary-token parameter when aux tokens are actually used.
With
num_register_tokens == num_class_tokens == 0, a zero-size parameter still participates in autograd and yields an empty gradient, which makes FSDP2's reduce-scatter fail with"RuntimeError: _chunk_cat expects non-empty tensor".Description
Issue Number
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60