Skip to content

fix requirement that fe_diffusion is specified in config - #2684

Open
clessig wants to merge 2 commits into
develop-ssl-diffusion-v1from
clessig/develop-ssl-diffusion-v1/fix_diffusion_required
Open

fix requirement that fe_diffusion is specified in config#2684
clessig wants to merge 2 commits into
develop-ssl-diffusion-v1from
clessig/develop-ssl-diffusion-v1/fix_diffusion_required

Conversation

@clessig

@clessig clessig commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Description

fix requirement that fe_diffusion is specified in config. Also linting and some incomplete merge.

Issue Number

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@github-actions github-actions Bot added eval anything related to the model evaluation pipeline model Related to model training or definition (not generic infra) labels Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval anything related to the model evaluation pipeline model Related to model training or definition (not generic infra)

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant