make srdrwfy6 inference work - #2674
Open
Jubeku wants to merge 2 commits into
Open
Conversation
clessig
reviewed
Jul 22, 2026
| # not present here and are skipped instead of raising a ValueError. | ||
| requested = stream_info.get("geoinfo_channels") | ||
| missing = [ch for ch in requested if ch not in ds.variables] | ||
| if missing: |
| n_pred_steps = len(model_output.physical) | ||
| if n_pred_steps > len(timestep_idxs): | ||
| timestep_idxs = list(range(forecast_offset, forecast_offset + n_pred_steps)) | ||
| # # Diffusion inference inflates the model output's fstep dimension to one entry per |
Collaborator
There was a problem hiding this comment.
Is it useful to keep this for debug purposes?
4 tasks
#2676) * draft of changes to make inference with develop-ssl trained srdrwfy6 work * Restore _expand_targets_to_match_preds function Restore target expansion logic to handle multiple forecast steps and improve clarity in the warning messages. --------- Co-authored-by: Sebastian Hickman <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inference is run as follows:
Results into:
Seb's baseline:
Description
Issue Number
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60