Skip to content

[2624] Refactor throughput logging - #2629

Open
florianscheidl wants to merge 6 commits into
ecmwf:developfrom
florianscheidl:dev/lighter-throughput-logging
Open

[2624] Refactor throughput logging#2629
florianscheidl wants to merge 6 commits into
ecmwf:developfrom
florianscheidl:dev/lighter-throughput-logging

Conversation

@florianscheidl

@florianscheidl florianscheidl commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Description

Log less frequently to avoid overhead, include logging in the _log function.
We rename the config argument from train_logging.track_performance_metrics to train_logging.throughput_tracking (more control over which metrics are tracked).

Issue Number

Fixes #2624.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@florianscheidl
florianscheidl marked this pull request as ready for review July 13, 2026 12:21
@github-actions github-actions Bot added eval anything related to the model evaluation pipeline performance Work related to performance improvements labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eval anything related to the model evaluation pipeline performance Work related to performance improvements

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Smaller throughput tracker

1 participant