Support channel binding configuration in PgConnectOptions#1671
Merged
Conversation
Member
|
Can you please sign the Eclipse ECA? Would you mind adding the option field to connect options while you're at it? |
Member
|
Ideally we'd also have a test that verifies it is not possible to connect if the user sets the |
jorsol
changed the title
Contributor
Author
|
@tsegismont Could you please review again? I'm not fully familiar with the code base, so maybe you can point me to improvements. |
jorsol
force-pushed
the
update-scram-3.3
branch
8 times, most recently
from
312e6a4 to
86caa70
Compare
tsegismont
reviewed
Jun 15, 2026
tsegismont
reviewed
Jun 15, 2026
tsegismont
left a comment
tsegismont
left a comment
Member
There was a problem hiding this comment.
Thank you @jorsol ! Please find a few comments
Introduce support for configuring channel binding mechanisms during the SCRAM-SHA-256-PLUS authentication handshake. This allows users to enforce, prefer, or disable channel binding securely. - Add channelBinding property and getters/setters to PgConnectOptions - Update PgConnectionUriParser to parse 'channel_binding' from connection URIs - Store channel binding preference in Netty Channel attributes during initialization - Propagate the configuration to ScramAuthentication to negotiate -PLUS variants - Fail the connection handshake if a mismatch or unsupported negotiation occurs Signed-off-by: Jorge Solorzano <[email protected]>
Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Introduce support for configuring channel binding mechanisms during the
SCRAM-SHA-256-PLUS authentication handshake. This allows users to require,
prefer, or disable channel binding securely.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines