CW_24 export#157
Draft
Y-Vaishnavi wants to merge 6 commits into
Draft
Conversation
- Remove string_literal dependency from mw/log GIT_ORIGIN_SPP_REV_ID: 0265646551b42ab8c6ced0729298cd497bd71b55
Use the implementation in score_baselibs and delete it from spp. GIT_ORIGIN_SPP_REV_ID: f4abc30c1e257cd76948aa063dd7f929d8ee4a34
GIT_ORIGIN_SPP_REV_ID: e03524de20aa62d1975be2260992b317fb322f04
GIT_ORIGIN_SPP_REV_ID: 3becb088f47af50760e0c16bf5b1824c1a652030
- include pthread OS wrapper in socketserver public header to avoid incomplete bmw::os::Pthread type usage - remove pthread forward declaration - Avoid using forward declaration and use include instead This is in line with Google's c++ stype guide https://google.github.io/styleguide/cppguide.html#Forward_Declarations GIT_ORIGIN_SPP_REV_ID: 6fe6742932aa487a83909e896a3c1d440c3f66dd
GIT_ORIGIN_SPP_REV_ID: ed8f4b89eb299614fdc773d1e62c18e50e8184b8
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #