Skip to content

CW_24 export#157

Draft
Y-Vaishnavi wants to merge 6 commits into
eclipse-score:mainfrom
Y-Vaishnavi:5A6A3ABB4B74F4375B4D7C51733A2996
Draft

CW_24 export#157
Y-Vaishnavi wants to merge 6 commits into
eclipse-score:mainfrom
Y-Vaishnavi:5A6A3ABB4B74F4375B4D7C51733A2996

Conversation

@Y-Vaishnavi

Copy link
Copy Markdown
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

jianjun and others added 6 commits June 24, 2026 17:10
- Remove string_literal dependency from mw/log

GIT_ORIGIN_SPP_REV_ID: 0265646551b42ab8c6ced0729298cd497bd71b55
Use the implementation in score_baselibs and delete it from spp.

GIT_ORIGIN_SPP_REV_ID: f4abc30c1e257cd76948aa063dd7f929d8ee4a34
GIT_ORIGIN_SPP_REV_ID: e03524de20aa62d1975be2260992b317fb322f04
GIT_ORIGIN_SPP_REV_ID: 3becb088f47af50760e0c16bf5b1824c1a652030
- include pthread OS wrapper in socketserver public header to
  avoid incomplete bmw::os::Pthread type usage
- remove pthread forward declaration
- Avoid using forward declaration and use include instead
  This is in line with Google's c++ stype guide
  https://google.github.io/styleguide/cppguide.html#Forward_Declarations

GIT_ORIGIN_SPP_REV_ID: 6fe6742932aa487a83909e896a3c1d440c3f66dd
GIT_ORIGIN_SPP_REV_ID: ed8f4b89eb299614fdc773d1e62c18e50e8184b8
@github-actions

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 068ef773-32fe-434b-afce-c461646434aa
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 5.578s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

4 participants