mw/com: Remove updating of service element in ProxyBase#593
Draft
bemerybmw wants to merge 1 commit into
Draft
Conversation
Previously, each service element had to store a reference to the parent ProxyBase so that it could update the reference to itself in the ProxyBase when the service element was moved. This meant that both ProxyBase and the service elements had to store references to each other. Keeping these references in a valid state during moving was complex and error prone. Each service element now inherits from EnableReferenceToMoveableFromThis which stores a ReferenceToMoveableOwner element which is updated when the service element moves. The ProxyBase stores a ReferenceToMoveable::Reference to each service element, instead of a regular reference which is now always valid, regardless of moving of the ProxyBase or service elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, each service element had to store a reference to the parent ProxyBase so that it could update the reference to itself in the ProxyBase when the service element was moved. This meant that both ProxyBase and the service elements had to store references to each other. Keeping these references in a valid state during moving was complex and error prone.
Each service element now inherits from EnableReferenceToMoveableFromThis which stores a ReferenceToMoveableOwner element which is updated when the service element moves. The ProxyBase stores a ReferenceToMoveable::Reference to each service element, instead of a regular reference which is now always valid, regardless of moving of the ProxyBase or service elements.
Depends-on: #572