Avoid Console logging as validation mechanism#589
Open
ahmed0mousa wants to merge 9 commits into
Open
Conversation
LittleHuba
requested review from
LittleHuba,
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
LittleHuba
reviewed
Jun 24, 2026
LittleHuba
left a comment
LittleHuba
left a comment
Contributor
There was a problem hiding this comment.
In many tests you drop the check that the logs contain a specific substring. Was this an active decision by you? Could you highlight the process how you came to this decision please?
…y test Issue: 267
…ent type test Issue: 267
…iguration test Issue: 267
…tance identifier test Issue: 267
…awler test Issue: 267
…ime test Issue: 267
…ent identifier test Issue: 267
…er test Issue: 267
…ime trace test Issue: 267
ahmed0mousa
force-pushed
the
ahmo_avoid_console_logging
branch
from
d3a997f to
7815134
Compare
Contributor
Author
|
I add the missed expectations for checking that the logs contain a specific substring. now there are only two tests in |
LittleHuba
approved these changes
Jun 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.