Fix channel-frequency mapping in compute_MVBS#1698
Open
LOCEANlloydizard wants to merge 1 commit into
Open
Conversation
leewujung
approved these changes
Jul 11, 2026
leewujung
left a comment
leewujung
left a comment
Member
There was a problem hiding this comment.
@LOCEANlloydizard : Thanks for this PR! Look great and I think it's ready to be merged.
The only thing I wonder about is why the ping_time dimension shows up in frequency_nominal. Is there something that should be fixed upstream?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a channel/frequency mismatch in
compute_MVBSfor datasets wherefrequency_nominalis stored as(ping_time, channel)(e.g. AZFP). The output now preserves the channel order returned bycompute_raw_MVBSand alignsfrequency_nominalaccordingly. Also added regression tests but I'll keep #1682 open, as I'd like to add a few more tests! (like with AZFP file)Ref #1682