Skip to content

Lat lon update #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccathomas-NOAA wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Lat lon update #507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3662cae
minor fix to allow either INPFC or ks statification
rebeccathomas-NOAA May 21, 2026
c0876e9
Merge branch 'main' of https://github.com/rebeccathomas-NOAA/echopop
rebeccathomas-NOAA May 28, 2026
be03c4b
Fix in read_echoview_export in nasc.py to use lat_s instead of lat_m …
rebeccathomas-NOAA Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions echopop/ingest/nasc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ def read_echoview_export(filename: Path, validator: Any | None = None) -> pd.Dat
col = next(iter(lon_columns))
df.rename(columns={col: "longitude"}, inplace=True)
# ---- If > 1 is present and includes 'lon_m'
elif len(lon_columns) > 1 and "lon_m" in lon_columns:
df.rename(columns={"lon_m": "longitude"}, inplace=True)
elif len(lon_columns) > 1 and "lon_s" in lon_columns:
df.rename(columns={"lon_s": "longitude"}, inplace=True)

# Disambiguate possible overlapping longitude column names
# ---- Intersecting names
Expand All @@ -385,8 +385,8 @@ def read_echoview_export(filename: Path, validator: Any | None = None) -> pd.Dat
col = next(iter(lat_columns))
df.rename(columns={col: "latitude"}, inplace=True)
# ---- If > 1 is present and includes 'lon_m'
elif len(lat_columns) > 1 and "lat_m" in lat_columns:
df.rename(columns={"lat_m": "latitude"}, inplace=True)
elif len(lat_columns) > 1 and "lat_s" in lat_columns:
df.rename(columns={"lat_s": "latitude"}, inplace=True)

# Rename columns used by Echopop
df.rename(columns=ECHOVIEW_TO_ECHOPOP, inplace=True)
Expand Down
Loading