fakecgo: add s390x support for CGO_ENABLED=0#422
Conversation
hajimehoshi
left a comment
There was a problem hiding this comment.
Interesting, but we cannot have tests right now, right?
that's correct, the upstream fix only exists in master so we can test using the above docker command but unfortunely setup-go doesn't support gotip and manually running this would significantly slow down CI. I'd suggest that given that's unsupported until 1.27 you can just enable the testing at that point? |
|
I suggest to hold this PR until Go 1.27 release candidate is released |
yup, I'm totally fine with this, I wanted to just get the assembly in a git repo somewhere so we didn't lose it :) |
@hajimehoshi I've updated this to use the 1.27.0 rc1 |
|
The tests are failing now |
sorry had to push one other fix, this should be good now |
|
@hajimehoshi updated PTAL |
hajimehoshi
left a comment
There was a problem hiding this comment.
LGTM
@TotallyGamerJet PTAL
What type of issue is this addressing?
feature
What this PR does | solves
Adds support for
CGO_ENABLED=0on s390x. Note that this will only work for Go 1.27+.For those who want to test this you can easily do this via a docker container: