Ruby19#2
Open
gilles wants to merge 2 commits into
Open
Conversation
Author
|
I think I found it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The current gem does not work with ruby 1.9.X. because of encoding issues (even though the file is ISO-8859-1 the default IO seems to be ASCII-8BIT)
Here is the first phase of a possible fix.
The tests still fails because of
RegexpError:
invalid multibyte escape: /^Der gro\xdfe BilderSauger.*?$/
I don't have a solution for this one yet.
I found a thread of ruby-forum which said to replace
with
it works with warnings but this is undocumented black magic, I don't really like it.
If you have a solution for the second phase that would be awesome :)
Thanks
--Gilles