Fix race condition in sandbox multi-file writes - #233
Open
ayushnandi718-dev wants to merge 1 commit into
Open
Conversation
Replace forEach(async) fire-and-forget with await Promise.all() so all files are written to the sandbox before code execution starts. Fixes e2b-dev#229
ayushnandi718-dev
requested review from
ben-fornefeld,
mishushakov and
mlejva
as code owners
July 14, 2026 11:55
|
We require contributors to sign our Contributor License Agreement, and we don't have @ayushnandi718-dev on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
|
@ayushnandi718-dev is attempting to deploy a commit to the E2B Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@cla-bot check i did it |
|
The cla-bot has been summoned, and re-checked this pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multi-file fragments can execute before all files are written to the sandbox — a race condition in app/api/sandbox/route.ts.
Array.prototype.forEach ignores the promises returned by the async callback. The outer POST handler continues to sbx.runCode(...) / URL return without awaiting the writes.
Fix
Replaced orEach(async) with �wait Promise.all(fragment.code.map(...)) so all files are persisted before execution or URL return.
Closes #229