Bugfix/ignore outside densities - #900
Conversation
… all dose engines
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #900 +/- ##
==========================================
+ Coverage 55.46% 55.48% +0.01%
==========================================
Files 331 331
Lines 20906 20930 +24
==========================================
+ Hits 11596 11612 +16
- Misses 9310 9318 +8 ☔ View full report in Codecov by Harness. |
wahln
left a comment
wahln
left a comment
There was a problem hiding this comment.
This is very nice for computation consistency, thanks.
The code itself looks very nice, but could you add some minimal tests to check the correct behavior? Probably its difficult to catch the corresponding warnings, but you could probably check the resulting dose / generated stf's if you see the expected discrepancies.
|
Additionally, some documentation for this consistency between stf and dosecalc might be helpful |
i think to check the expected result i would have to create a new test ct, because our current dummy test ct only has air outside of the patient anyway. I could create a new one with a dummy couch to test the behavior |
…e, also solves octave/ matrad interpolation issue in tests
|
Final requests from my side:
|
done |
# Conflicts: # CHANGELOG.md
|
This PR was automatically marked as stale it has been open 30 days with no activity. Please review/update/merge this PR. |
# Conflicts: # matRad/MatRad_Config.m # matRad/doseCalc/+DoseEngines/matRad_TopasMCEngine.m # test/testData/helper_testDataCreater.m
…nerators and dose engines
2 participants
Making of ignoreOutsideDensities and useGivenEqDensityCube consistent between stf generation and dose engines, a problem for the dose engines arose because the analytcial calculation was performed on the RSP cube, where ignoreOutsideDensities was applied, but the MC would often dirrectly use the HU cube to do material conversion, where this was not applied