Skip to content

Fix drupal-lint and stylelint errors#805

Merged
jjroelofs merged 2 commits into
8.xfrom
fix/lint-errors
Apr 4, 2026
Merged

Fix drupal-lint and stylelint errors#805
jjroelofs merged 2 commits into
8.xfrom
fix/lint-errors

Conversation

@jjroelofs

Copy link
Copy Markdown
Collaborator

Summary

  • Add missing fall-through comment in dxpr_theme_preprocess_region() switch case (dxpr_theme.theme:423) to fix PHPCS error
  • Shorten 6-char hex colors to 3-char shorthand in darkmode color scheme (scss/base/variables.scss) to fix 6 stylelint color-hex-length errors
  • Update compiled css/base/variables.css to match

Fixes lint failures visible in PR #804 checks (and all other PRs targeting 8.x).

Test plan

  • Verify drupal-lint CI check passes
  • Verify stylelint CI check passes
  • Verify darkmode colors render correctly (values are identical: #222 = #222222, etc.)

Jurriaan Roelofs added 2 commits April 4, 2026 09:55
Add missing fall-through comment in switch case in
dxpr_theme_preprocess_region() and shorten 6-char hex colors to 3-char
shorthand in darkmode color scheme to satisfy color-hex-length rule.
- Wrap long lines to stay within 80-character limit in README.md,
  header-theme-settings-css.inc, and css-variables-theme-settings-css.inc
- Update PHPCompatibility to ^10.0@alpha for PHPCS 4.x support
  (9.x only supports PHPCS 3.x, causing installation failure)
@jjroelofs jjroelofs merged commit 9f6ee82 into 8.x Apr 4, 2026
3 checks passed
@jjroelofs jjroelofs deleted the fix/lint-errors branch April 4, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant