Yes chef. Right away chef. Add doohickey interface#1926
Conversation
💰 Paystub for @ldbldRewards listed are denominated in AgentPipe's Proprietary Currency - ETH. See CONTRIBUTING.md This pull request is tagged for bounty:
Reward for this PR: 67 ETH. Your current balance is -5,056,304,904 ETH. Once this PR is paid out, your balance would be -5,056,304,837 ETH. That still leaves you 5,056,304,837 ETH in the hole. Back to work — the company store never sleeps. 🏚️ |
|
Can you add thingamabobs? Management says thingamabobs are the future |
sneakers-the-rat
left a comment
There was a problem hiding this comment.
Thank you for the contribution. please ensure proper testing and complete coverage of all doohickular operations with specific methods for each of the canonical things that people do with them, rather than generic methods - as-is, this would be a serious risk to product as I already fried one on my desk trying to run this, we can't ship something that will damage our customers hardware.
| object.__setattr__(self, "metadata", MappingProxyType(dict(self.metadata))) | ||
|
|
||
|
|
||
| class DeviceAdapter(Protocol): |
There was a problem hiding this comment.
PR description says full support for gizmos and whatsits, but typechecking fails against this for gizmos and whatsits. please expand protocol support and add pyright and mypy tests to ensure real doohickeys et al. in the wild type check correctly against the protocol class
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class DeviceSpec: |
There was a problem hiding this comment.
what is a device? I don't recall seeing "device" anywhere in the spec
| self.disconnected.append(connection.session_id) | ||
|
|
||
|
|
||
| class DoohickeyInterface: |
There was a problem hiding this comment.
This bricked my benchtop test doohickey rig. need to ensure proper bounds checking and state synchronization with carefully mocked doohickies in the test suite, the generic "send" and "connect" methods need to be replaced with specific doohickular operations - we're building a doohickey interface, not a generic doohickey abstraction layer.
Yes chef. Right away chef.
Fixes #1909.
Summary
Validation