Skip to content

DDS-007D: Polish public navigation and accessibility - #31

Merged
klaasnicolaas merged 1 commit into
mainfrom
codex/dds-007d-public-navigation
Jul 26, 2026
Merged

DDS-007D: Polish public navigation and accessibility#31
klaasnicolaas merged 1 commit into
mainfrom
codex/dds-007d-public-navigation

Conversation

@klaasnicolaas

Copy link
Copy Markdown
Member

Summary

  • finalize the DDS-007D public navigation hierarchy across desktop, mobile, and footer links
  • add accurate current-page states, a skip link, a single labelled primary navigation landmark, and safer external-link announcements
  • make the mobile menu contain focus, close with Escape, restore trigger focus, lock body scrolling, and isolate background content
  • fix contrast issues found by the representative public-page accessibility scan
  • expand browser coverage for keyboard interaction, active states, mobile behavior, and public accessibility
  • record DDS-014K as a completed no-build decision and queue DDS-014N for the dedicated code-owned Over DDS page
  • keep Contact in the main navigation without duplicating email or demo links in the footer

Why

The shared public shell still had inconsistent active states, nested navigation landmarks, and incomplete keyboard behavior. The mobile menu did not contain focus or isolate the page behind it. The backlog also still presented the already-recorded DDS-014K decision as upcoming work and lacked a concrete ticket for replacing the generic /about shell.

Impact

Visitors get a more predictable and accessible navigation experience on desktop and mobile. The next implementation work is now represented accurately without introducing speculative guide or fixed-page CRUD.

Validation

  • npm run build
  • npm run types:check
  • targeted ESLint for the changed React files
  • Prettier check for changed React and Markdown files
  • vendor/bin/pint --dirty --format agent
  • php artisan test --compact tests/Browser/PublicSiteTest.php — 18 tests, 396 assertions
  • git diff --check

@klaasnicolaas
klaasnicolaas marked this pull request as ready for review July 26, 2026 22:04
Copilot AI review requested due to automatic review settings July 26, 2026 22:04
@klaasnicolaas klaasnicolaas changed the title Polish public navigation and accessibility DDS-007D: Polish public navigation and accessibility Jul 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the public-site navigation and accessibility behavior across desktop, mobile, and footer, and aligns supporting product/backlog documentation with the updated public IA decisions.

Changes:

  • Improves public navigation semantics and current-page states (header, footer, events CTA) and adds a keyboard-accessible skip link.
  • Hardens the mobile menu UX with focus containment, Escape-to-close + focus restoration, background scroll locking, and background content isolation.
  • Updates browser tests and product/backlog docs to reflect the finalized navigation hierarchy and the DDS-014K no-build decision / DDS-014N next ticket.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/Browser/PublicSiteTest.php Extends browser coverage for skip link, safe external-link labels, footer link decisions, menu focus/escape/scroll locking, inert isolation, and accessibility scan checks.
resources/js/pages/welcome.tsx Adjusts text colors to address contrast issues found in accessibility scanning.
resources/js/layouts/public-layout.tsx Implements skip link, active/current-page states, safer external-link announcements, footer active states, and mobile menu focus + scroll/inert isolation behavior.
resources/js/components/public/public-patterns.tsx Tweaks FeatureCard index color to improve contrast (light/dark).
docs/product/information-architecture.md Updates the documented public navigation hierarchy and label policy to match the implemented shell.
docs/product/getting-started-knowledge-hub.md Records DDS-014K as a no-build decision and reframes the conditional future guide-library phase.
docs/backlog/open-work-execution-order.md Updates current focus and ordered work to reflect DDS-007D status and DDS-014N as next.
docs/backlog/initial-build-backlog.md Updates backlog status text and expands DDS-007D / DDS-014K / DDS-014N documentation to match current decisions and scope.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@klaasnicolaas
klaasnicolaas merged commit dcb4c03 into main Jul 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants