DDS-007D: Polish public navigation and accessibility - #31
Merged
Conversation
klaasnicolaas
marked this pull request as ready for review
July 26, 2026 22:04
There was a problem hiding this comment.
Pull request overview
This PR finalizes the public-site navigation and accessibility behavior across desktop, mobile, and footer, and aligns supporting product/backlog documentation with the updated public IA decisions.
Changes:
- Improves public navigation semantics and current-page states (header, footer, events CTA) and adds a keyboard-accessible skip link.
- Hardens the mobile menu UX with focus containment, Escape-to-close + focus restoration, background scroll locking, and background content isolation.
- Updates browser tests and product/backlog docs to reflect the finalized navigation hierarchy and the DDS-014K no-build decision / DDS-014N next ticket.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Browser/PublicSiteTest.php | Extends browser coverage for skip link, safe external-link labels, footer link decisions, menu focus/escape/scroll locking, inert isolation, and accessibility scan checks. |
| resources/js/pages/welcome.tsx | Adjusts text colors to address contrast issues found in accessibility scanning. |
| resources/js/layouts/public-layout.tsx | Implements skip link, active/current-page states, safer external-link announcements, footer active states, and mobile menu focus + scroll/inert isolation behavior. |
| resources/js/components/public/public-patterns.tsx | Tweaks FeatureCard index color to improve contrast (light/dark). |
| docs/product/information-architecture.md | Updates the documented public navigation hierarchy and label policy to match the implemented shell. |
| docs/product/getting-started-knowledge-hub.md | Records DDS-014K as a no-build decision and reframes the conditional future guide-library phase. |
| docs/backlog/open-work-execution-order.md | Updates current focus and ordered work to reflect DDS-007D status and DDS-014N as next. |
| docs/backlog/initial-build-backlog.md | Updates backlog status text and expands DDS-007D / DDS-014K / DDS-014N documentation to match current decisions and scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The shared public shell still had inconsistent active states, nested navigation landmarks, and incomplete keyboard behavior. The mobile menu did not contain focus or isolate the page behind it. The backlog also still presented the already-recorded DDS-014K decision as upcoming work and lacked a concrete ticket for replacing the generic
/aboutshell.Impact
Visitors get a more predictable and accessible navigation experience on desktop and mobile. The next implementation work is now represented accurately without introducing speculative guide or fixed-page CRUD.
Validation
npm run buildnpm run types:checkvendor/bin/pint --dirty --format agentphp artisan test --compact tests/Browser/PublicSiteTest.php— 18 tests, 396 assertionsgit diff --check