Skip to content

New evidence format#9

Open
sfc-gh-ajablonowski wants to merge 4 commits into
masterfrom
new_evidence_format
Open

New evidence format#9
sfc-gh-ajablonowski wants to merge 4 commits into
masterfrom
new_evidence_format

Conversation

@sfc-gh-ajablonowski

Copy link
Copy Markdown
Collaborator

Updating schema for new evidence format

@Borchmann

Copy link
Copy Markdown
Contributor

I don't think we can use pixels for coordinates. As PDFs have no native resolution, document.json should be resolution-agnostic. I suggest using relative positions (normalized by the height and width).

@sfc-gh-ajablonowski

Copy link
Copy Markdown
Collaborator Author

Ok, we have bounding boxes in pixels returned by the model and in some datasets, in both cases normalised values are used and bounding box in pixels is just additional optional information, I'm going to consult on solutions and notify here.

@sfc-gh-djurkiewicz-1

Copy link
Copy Markdown

We could use bounding boxes in pixels internally and, here, use just the normalized values.

@sfc-gh-ajablonowski

Copy link
Copy Markdown
Collaborator Author

Ok, I removed bounding boxes in pixels from the schema.

@sfc-gh-ajablonowski

sfc-gh-ajablonowski commented Nov 5, 2024

Copy link
Copy Markdown
Collaborator Author

I changed fields "positions" and "group_item_ids" in evidence to optional.

@sfc-gh-lborchmann

Copy link
Copy Markdown

It looks good now, but please add an example of how to use group_item_ids in the examples directory.

@sfc-gh-ajablonowski

Copy link
Copy Markdown
Collaborator Author

group_item_ids is a field used only by graphical interface in our services to know how to highlight bounding boxes, in our work we set it always to 0 currently.

@sfc-gh-ajablonowski

Copy link
Copy Markdown
Collaborator Author

Is it ok to leave group_item_ids set to zeros in examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants