Fix clippy::needless_late_init#156
Open
nyurik wants to merge 1 commit into
Open
Conversation
nyurik
force-pushed
the
needless-late-init
branch
2 times, most recently
from
March 18, 2024 15:50
0c04667 to
8bebfce
Compare
nyurik
force-pushed
the
needless-late-init
branch
5 times, most recently
from
April 8, 2024 01:08
c22e55d to
113c318
Compare
nyurik
force-pushed
the
needless-late-init
branch
2 times, most recently
from
April 18, 2024 06:56
c4053df to
972726e
Compare
nyurik
force-pushed
the
needless-late-init
branch
2 times, most recently
from
May 1, 2024 18:36
68e105a to
372b92d
Compare
Contributor
Author
|
@danielrh hi, any blockers for this and a few other PRs to merge? Thx |
nyurik
force-pushed
the
needless-late-init
branch
4 times, most recently
from
May 11, 2024 06:36
a0eaac8 to
2c40280
Compare
Contributor
Author
|
is this one ok to merge? |
nyurik
force-pushed
the
needless-late-init
branch
2 times, most recently
from
May 21, 2024 13:13
0465516 to
83bd422
Compare
nyurik
force-pushed
the
needless-late-init
branch
from
May 27, 2024 11:29
83bd422 to
db8c9d0
Compare
Used `cargo clippy -- -A clippy::all -W clippy::needless_late_init` to find all such cases, and manually fix them Additionally simplified logic in backward_references/hq.rs, and converted while into for loop there
nyurik
force-pushed
the
needless-late-init
branch
from
May 28, 2024 03:02
db8c9d0 to
17b19f1
Compare
Contributor
Author
|
@danielrh hi, are you still looking at these? thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used
cargo clippy -- -A clippy::all -W clippy::needless_late_initto find all such cases, and manually fix themAdditionally simplified logic in backward_references/hq.rs, and converted while into for loop there