feat: osu!mania -> quaver reverse conversion (+ combo/positioning fixes) - #5
Merged
Conversation
Owner
Author
|
so sorry to the people i accidentally @'d my bad guys |
dromzeh
marked this pull request as ready for review
July 24, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2, closes #3, closes #4
three for one: both open fixes plus the reverse direction. the fun part - the gist formulas are the osu!->quaver direction already (the existing converters are their inverses), so the reverse coordinate math was basically free and round-trips exactly (there's a test: ComboPosY -> ComboPosition -> ComboPosY is lossless).
the fixes
how the reverse works
@2xfallbacks (halved back to@1xmetrics). LN tails flip back, health bars rotate back to vertical, lighting animations get recomposed into quaver's@1xNspritesheets, judgements/fonts/grades/hitsounds all map back.notes
test