[lxc-android] Fix added support for process accounting.#12
Open
Bettehem wants to merge 1 commit into
Open
Conversation
On systems without cgroupv2, having this last lxc.mount.entry would prevent the system from booting properly. Making it optional solves such problems.
Member
|
ah awesome, that's even better than adding a new hook :) Thanks @bellegarde-c could you check if it works as expected on miatoll? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in the
lxc.mount.entrysection in the lxc documentation: "Moreover lxc supports mount propagation, such as rshared or rprivate, and adds three additional mount options. optional don't fail if mount does not work."So if we just use the
optionalmount option, it doesn't fail on cgroupv1 systems:lxc.mount.entry = none acct cgroup2 rw,nosuid,nodev,noexec,relatime,nsdelegate,memory_recursiveprot,optional 0 0Tested this on my OnePlus 3T, which doesn't have cgroupv2