fix(ostool): harden local U-Boot TFTP staging lifecycle#156
Merged
Conversation
There was a problem hiding this comment.
本 PR 将 Linux 系统 tftpd-hpa 的 FIT 暂存改为受限的 ostool/<唯一目录> 命名空间,并在本地 U-Boot 运行收尾阶段清理文件和目录;同时把网络配置归入本地配置结构,并补充了中英文权限配置说明。改动影响本地 Linux 的 U-Boot/TFTP 启动与清理路径;远程开发板上传路径保持独立,未发现共享 API 或配置契约回归。
审查结论:暂存路径验证、冲突处理、失败回滚及清理错误聚合均有针对性测试覆盖;未发现未解决问题或额外测试缺口。未发现既有审查意见或讨论需要跟进;相似 PR 搜索未发现重叠项。
验证:GitHub Actions check (stable, x86_64-unknown-linux-gnu) 已成功(包含 CI 的格式化、clippy、构建和测试流程)。本地已通过 git diff --check 并复核目标 HEAD;本地环境未安装 cargo,因此无法在此环境重跑 cargo fmt --check、cargo clippy --manifest-path ostool/Cargo.toml --all-features -- -D warnings 和 cargo test --manifest-path ostool/Cargo.toml --all-features。CI 无由本 PR 引起的失败。
Powered by gpt-5.6-terra
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix local U-Boot network configuration handling and make Linux TFTP staging shorter, safer, and automatically cleaned after each run.
Changes
[net]section work directly withLocalBackend, including settings such asinterfaceandtftp_dir.Compatibility
The existing TOML format remains unchanged:
Remote board execution is unaffected because its network configuration continues to come from the server boot profile.