fix: stream non-textual responses through untouched#55
Open
erichurkman wants to merge 1 commit into
Open
Conversation
Non-textual responses (PDFs, fonts, and other file attachments) were being read with response.text(), which does a lossy UTF-8 decode/re-encode round-trip that corrupts the bytes. The browser then receives a broken file and can't render it. Detect the content-type and pass binary bodies straight through; only HTML/CSS/JS/JSON/XML get rewritten. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Author
|
This was tested in our local notion host. Some PDFs rendered fine, but others didn't. Others rendered some fonts, but not others. This fixed it for all embeds we tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-textual responses (PDFs, fonts, and other file attachments upstream in Notion) were being read with response.text(), which does a lossy UTF-8 decode/re-encode round-trip that corrupts the bytes. The browser then receives a broken file and can't render it. (Saw this specifically with PDFs.)
Detect the content-type and pass binary bodies straight through the proxy.