implementation of CSI-919#249
Open
ric-sysdig wants to merge 1 commit into
Open
Conversation
jonathangordon-sysdig
approved these changes
May 19, 2026
jonathangordon-sysdig
left a comment
jonathangordon-sysdig
left a comment
There was a problem hiding this comment.
Looks good, better feedback for the user.
For line 306, should it say "completed!" even if the copy fails?
Contributor
Author
For now, I would leave it as is. I'll note this when I have to do another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, kubectl cp may fail for other reasons not related to tar, and the current EH do not cover this.
Added a better EH to see, in the activity.log, the eventual error returned by kubectl cp.