[cDAC] Implement DacDbi GetCollectibleTypeStaticAddress#128288
Open
Copilot wants to merge 2 commits into
Open
Conversation
Co-authored-by: rcj1 <[email protected]>
Co-authored-by: rcj1 <[email protected]>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
rcj1
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cDAC RuntimeTypeSystem contract to allow callers to choose whether value-type statics/thread-statics should be dereferenced (“unboxed”) when computing their addresses, and then uses that capability to implement DacDbiImpl.GetCollectibleTypeStaticAddress in the non-legacy path.
Changes:
- Implement
DacDbiImpl.GetCollectibleTypeStaticAddressviaIRuntimeTypeSystem.GetFieldDescStaticAddress(..., unboxValueTypes: false). - Extend
IRuntimeTypeSystem.GetFieldDescStaticAddress/GetFieldDescThreadStaticAddresswith aunboxValueTypesparameter and thread it throughRuntimeTypeSystem_1. - Update the RuntimeTypeSystem design doc to describe the new parameter/semantics.
Show a summary per file
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs | Implements GetCollectibleTypeStaticAddress using the RuntimeTypeSystem contract and validates against legacy in DEBUG. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/RuntimeTypeSystem_1.cs | Adds unboxValueTypes plumbing to the shared static/thread-static address resolver and interface implementations. |
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IRuntimeTypeSystem.cs | Updates the contract method signatures to include the optional unboxValueTypes parameter. |
| docs/design/datacontracts/RuntimeTypeSystem.md | Documents the new parameter and clarifies boxed-vs-unboxed address behavior. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust
GetFieldDescStaticAddressandGetFieldDescThreadStaticAddressto take a parameter of whether to unbox boxed value types.