JIT: Rename fields in indirect call transformer#128274
Open
jakobbotsch wants to merge 5 commits into
Open
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR JIT’s IndirectCallTransformer implementation by renaming internal fields (primarily adopting an m_ prefix) across the transformer classes in src/coreclr/jit/indirectcalltransformer.cpp.
Changes:
- Renamed
compilerand various transformer fields tom_*names for consistency. - Switched several members from constructor initialization to in-class default initialization.
- Updated call sites throughout the file to use the renamed members.
Open
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/coreclr/jit/indirectcalltransformer.cpp:1363
- Typo in comment: “high-likehood” should be “high-likelihood”.
// (also consider: if m_currBlock has sufficiently high execution frequency)
//
// We want to see if it makes sense to mark the subsequent GDV site as a "chained"
// GDV, where we duplicate the code in between to stitch together the high-likehood
// outcomes without a join.
Member
Author
|
cc @AndyAyersMS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.