[cDAC] Implement DacDbi API GetSymbolsBuffer#128256
Open
Copilot wants to merge 5 commits into
Open
Conversation
…in cDAC Co-authored-by: rcj1 <[email protected]>
…dule in-memory-symbols dump test Co-authored-by: rcj1 <[email protected]>
Copilot
AI
changed the title
Implement cDAC GetSymbolsBuffer and GetInMemorySymbolStream
Revert to TryGetSymbolStream and add in-memory-symbols dump test
May 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements and tests managed cDAC/DacDbi support for retrieving in-memory symbol streams from modules, including dump coverage using a MultiModule debuggee that loads an assembly with in-memory PDB bytes.
Changes:
- Adds mock support for
CGrowableSymbolStreamand unit tests forILoader.TryGetSymbolStream. - Implements
DacDbiImpl.GetSymbolsBufferusing the Loader contract and adds unit coverage. - Extends the MultiModule dump debuggee/test coverage to exercise in-memory PDB symbol buffers.
Show a summary per file
| File | Description |
|---|---|
src/native/managed/cdac/tests/MockDescriptors/MockDescriptors.Loader.cs |
Adds mock growable symbol stream layout and helper allocation. |
src/native/managed/cdac/tests/LoaderTests.cs |
Registers the symbol stream type and tests loader symbol stream behavior. |
src/native/managed/cdac/tests/DumpTests/Debuggees/MultiModule/Program.cs |
Loads the debuggee assembly from bytes with PDB bytes for dump testing. |
src/native/managed/cdac/tests/DumpTests/DacDbi/DacDbiMultiModuleDumpTests.cs |
Adds dump integration coverage for GetSymbolsBuffer. |
src/native/managed/cdac/tests/DacDbiImplTests.cs |
Adds unit tests for DacDbiImpl.GetSymbolsBuffer. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/Dbi/DacDbiImpl.cs |
Implements managed GetSymbolsBuffer. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
rcj1
added
area-Diagnostics-cdac
and removed
NO-REVIEW
rcj1
changed the title
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
GetSymbolsBufferand add unit tests.