Add ECMA-335 EnC metadata delta writer#20019
Draft
NatElkins wants to merge 1 commit into
Draft
Conversation
Adds an internal, standalone ECMA-335 Edit-and-Continue metadata delta writer to AbstractIL: delta #- table stream and heap construction (DeltaMetadataTables, DeltaMetadataSerializer, DeltaTableLayout, DeltaIndexSizing), ECMA-335 II.24.2.6 coded-index encoding (DeltaMetadataEncoding), EncLog/EncMap emission, generation GUID chaining, user-string and standalone-signature token calculators (IlxDeltaStreams), and the coordinating writer (FSharpDeltaMetadataWriter) over a plain row-description input model (DeltaMetadataTypes, ILDeltaHandles, ILMetadataHeaps). The writer's inputs are row records (names, tokens, signatures, RVAs) plus heap offsets; it has no dependency on any semantic diffing or session machinery. It compiles with no in-tree consumer by design: the consumer is the F# hot reload work in dotnet#19941, following the same upstreaming pattern as dotnet#20017 and dotnet#20018 (land isolated, test-covered infrastructure first, wire the feature in a later PR). One line of ilwrite.fsi is touched to expose the pre-existing markerForUnicodeBytes so the delta writer reuses the exact string-marker logic of the full writer. No behavior change for any existing code path. Tests (130): coded-index encodings asserted against the production definitions and ECMA-335 II.24.2.6 order, System.Reflection.Metadata reader parity over emitted deltas, EncLog/EncMap correctness, stream layout, heap and index sizing, multi-generation heap-offset chaining asserted against computed expected values, standalone-signature rows asserted at baseline+1 from a real seeded baseline, and serializer failure paths.
NatElkins
force-pushed
the
enc-metadata-delta-writer
branch
from
bf3d940 to
73cc205
Compare
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an internal, standalone ECMA-335 Edit-and-Continue metadata delta writer to AbstractIL, with focused System.Reflection.Metadata-readable metadata tests. It has no behavior change and no in-tree semantic consumer yet; the consumer is the F# hot reload work in #19941. This follows the same upstreaming pattern as #20017 and #20018: land isolated infrastructure first, with deterministic byte and layout evidence, then wire the feature in a later PR.
What
Ten new internal AbstractIL files (file names kept from the development branch for diffability):
ILDeltaHandles- offset/handle primitives, coded-index discriminated unions, delta tokensILMetadataHeaps- heap sizes and offset bookkeepingIlxDeltaStreams- user-string and standalone-signature token calculators (continue numbering from a baseline)DeltaMetadataEncoding- ECMA-335 II.24.2.6 coded-index encodingDeltaMetadataTypes- the writer's input model: plain row-description records (method/parameter/property/event rows, method-semantics updates, custom attribute rows) and the definition key typesDeltaMetadataTables/DeltaTableLayout/DeltaIndexSizing/DeltaMetadataSerializer- delta#-table stream, heap construction, layout and index sizing, EncLog/EncMap emission, generation GUID chainingFSharpDeltaMetadataWriter- the coordinating writerThe writer's inputs are row records (names, tokens, signature blobs, RVAs) plus baseline heap offsets and row counts. It imports nothing from any diffing, baseline, or session machinery; a grep gate for such imports is part of how the extraction was validated. One line of
ilwrite.fsiexposes the pre-existingmarkerForUnicodeBytesso the delta writer reuses the full writer's exact string-marker logic.Tests
130 tests in
tests/FSharp.Compiler.Service.Tests/DeltaMetadata/:Encoding.CodedIndicesdefinitions, with ECMA-335 II.24.2.6 table order cross-checked against System.Reflection.Metadata'sTableIndexas an independent reference;SrmReaderParityTests);baseline + 1from a real seeded baseline;All additions are internal; no public surface area change.