Split TypeMapAssemblyEmitter.cs into partial class files#11405
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
7 tasks
Move IL method body emission methods (EmitCreateInstance*, EmitUco*, EmitManagedConstructor*, WriteManagedTypeSignature, EmitRegisterNatives, AddUnmanagedCallersOnlyAttribute, AddActivationCtorRef, AddManagedCtorRef) into TypeMapAssemblyEmitter.MethodBodies.cs. Keep assembly infrastructure methods in the original file. No functional changes. Agent-Logs-Url: https://github.com/dotnet/android/sessions/6b5e841c-b76a-4a06-8127-5f96ee3d0440 Co-authored-by: jonathanpeppers <[email protected]>
Copilot
AI
changed the title
[WIP] Split TypeMapAssemblyEmitter.cs into partial class files
Split May 18, 2026
TypeMapAssemblyEmitter.cs into partial class files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeMapAssemblyEmitter.cswas 1712 lines with two distinct logical sections intermixed: assembly structure emission and IL method body emission. Split into partial class files for readability.TypeMapAssemblyEmitter.cs(805 lines): Assembly infrastructure — fields, constructor,Emit/EmitCore, type/member references, proxy type orchestration, attribute emission, generic type utilitiesTypeMapAssemblyEmitter.MethodBodies.cs(919 lines): IL body emission —EmitCreateInstance*,EmitUco*,EmitManagedConstructor*,EmitRegisterNatives,AddUnmanagedCallersOnlyAttribute, marshal encoding helpersPure file-organization refactoring. No logic, signature, or visibility changes. SDK-style csproj with implicit globbing means no project file update needed.