Remove stale TODO and dead code in AuthDigestSession.HA2#11401
Merged
Conversation
7 tasks
Agent-Logs-Url: https://github.com/dotnet/android/sessions/b7dc28ba-d7ba-4069-b511-764702ef32ee Co-authored-by: jonathanpeppers <[email protected]>
Copilot
AI
changed the title
[WIP] Remove stale TODO and dead code in AuthDigestSession.HA2 method
Remove stale TODO and dead code in AuthDigestSession.HA2
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes dead code from AuthDigestSession.HA2() (a no-op auth-int branch with TODO/commented-out code) and replaces it with an explanatory comment about auth-int being unsupported due to needing an entity-body hash.
Changes:
- Deleted the empty
if (QOP == "auth-int")block and stale TODO/commented-out line. - Added a comment documenting why
auth-intisn’t supported in this implementation.
jonathanpeppers
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty
if (QOP == "auth-int")block with a bare// TODOand commented-out code has been dead since the file was adapted from Mono'sSystem.Net.DigestClient. It does nothing at runtime.ifblock, bare// TODO, and commented-outha2 += ...lineauth-intQOP (RFC 7616) is unsupported since it requires the entity body hash