[tests] Fix ApplicationRunsWithDebuggerAndBreaks flakiness#11398
Open
jonathanpeppers wants to merge 1 commit into
Open
[tests] Fix ApplicationRunsWithDebuggerAndBreaks flakiness#11398jonathanpeppers wants to merge 1 commit into
jonathanpeppers wants to merge 1 commit into
Conversation
The `timeout` TimeSpan is shared between two consecutive wait loops. The first loop (wait for initial breakpoints) decrements it; the second loop (wait for the post-button-click breakpoint) then starts with whatever time is left, which on a slow CI machine can be near zero. Reset timeout to 60 seconds before the second loop so each phase has a full budget. Addresses #11320. Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a source of flakiness in the ApplicationRunsWithDebuggerAndBreaks device integration test by ensuring each of two sequential “wait for breakpoint” phases gets its own full timeout budget, instead of sharing a decremented TimeSpan.
Changes:
- Reset
timeoutto 60 seconds immediately before the second wait loop (post-button-click breakpoint wait).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
timeoutTimeSpanvariable inApplicationRunsWithDebuggerAndBreaksis shared between two consecutive wait loops. The first loop (wait for initial breakpoints to be hit) decrements it; the second loop (wait for the post-button-click breakpoint) then starts with whatever time is left, which on a slow CI machine can be near zero — causing a spurious assertion failure.Reset
timeoutto 60 seconds before the second loop so each phase has a full budget.Addresses #11320.