Skip to content

default: add omnicompletion bindings to minibuffer#8261

Open
LemonBreezes wants to merge 1 commit into
doomemacs:masterfrom
LemonBreezes:add-omni-completion-corfu-bindings-to-minibuffer
Open

default: add omnicompletion bindings to minibuffer#8261
LemonBreezes wants to merge 1 commit into
doomemacs:masterfrom
LemonBreezes:add-omni-completion-corfu-bindings-to-minibuffer

Conversation

@LemonBreezes

@LemonBreezes LemonBreezes commented Jan 30, 2025

Copy link
Copy Markdown
Contributor

This commit adds omnicompletion bindings to the minibuffer. This is only done for Corfu because we do not currently enable Company in the minibuffer. This is primarily because sometimes I want to insert a file name into the minibuffer and want to do so with C-x C-f. If you have any suggestions on improving this, please comment below. Not all the bindings are added, because some of them do not make sense in the minibuffer unless you wrap them with special forms.


  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off.
  • Any relevant issues or PRs have been linked to.
  • This a draft PR; I need more time to finish it.

@LemonBreezes LemonBreezes requested review from a team as code owners January 30, 2025 21:51
This commit adds omnicompletion bindings to the minibuffer. This is only
done for Corfu because we do not currently enable Company in the
minibuffer. This is primarily because sometimes I want to insert a file
name into the minibuffer and want to do so with C-x C-f. If you have any
suggestions on improving this, please comment below. Not all the
bindings are added, because some of them do not make sense in the
minibuffer unless you wrap them with special forms.
@LemonBreezes LemonBreezes force-pushed the add-omni-completion-corfu-bindings-to-minibuffer branch from 4016322 to 0c60389 Compare January 30, 2025 21:53
@LemonBreezes

Copy link
Copy Markdown
Contributor Author

@hlissner Hey, what do you think about this change? I have used it for over a year and it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant