Skip to content

Allow using both setHeader and resp w/ headers#294

Closed
iffy wants to merge 18 commits into
dom96:masterfrom
iffy:resp-extra-headers
Closed

Allow using both setHeader and resp w/ headers#294
iffy wants to merge 18 commits into
dom96:masterfrom
iffy:resp-extra-headers

Conversation

@iffy

@iffy iffy commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

Currently making a request of a handler like this will only include the Content-Type header. This change makes it so that the foo and bar headers are added to the response as well.

  get "/manyheaders":
    setHeader(responseHeaders, "foo", "foo")
    setHeader(responseHeaders, "bar", "bar")
    resp Http200, {"Content-Type": "text/plain"}, "result"

@iffy

iffy commented Feb 17, 2022

Copy link
Copy Markdown
Contributor Author

Oops; this includes the code from #267 as well. I can remake this PR if you'd like.

@dom96

dom96 commented Feb 20, 2022

Copy link
Copy Markdown
Owner

Yeah, please split it if you can.

@dom96

dom96 commented Jun 10, 2022

Copy link
Copy Markdown
Owner

Any news on this? :)

@iffy

iffy commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

I'll wait for #275 and then remake this when I can get some time

@dom96

dom96 commented Jul 17, 2022

Copy link
Copy Markdown
Owner

Friendly ping

@iffy

iffy commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

I've submitted #300 to do the minimal change.

@iffy iffy closed this Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants