Add $buildInfo tests#230
Conversation
Signed-off-by: PatersonProjects <[email protected]>
Signed-off-by: PatersonProjects <[email protected]>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (330+0 LOC, 7 files); LLM: Adds new test coverage for the $buildInfo diagnostic command plus supporting utilities, touching the compatibility tests component with moderate scope. If a label is wrong, remove it manually and ping |
Signed-off-by: PatersonProjects <[email protected]>
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class DiagnosticPropertyTest(BaseTestCase): |
There was a problem hiding this comment.
Open Discussion: I think we can combine this with DiagnosticErrorTest since it's one field extra. I am thinking in terms of maintainability. Do we have a specific reason why we need to separate them ?
There was a problem hiding this comment.
I like the separation just for the clarity of whether it is a success or error case, combination is possible though if you think the maintainability concern is a big one?
Signed-off-by: PatersonProjects <[email protected]>
2 participants
This PR adds the tests for the $buildInfo diagnostic command, as well as some utilities to help test all the diagnostic commands generally.
Ref: Issue #43
As this is the first set of tests in this area careful review and suggestions are welcome!