perf(scheduler): resolve projectPath from cache_meta instead of re-reading JSONLs#65
Open
JeanBaptisteRenard wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On every 60s scheduler tick,
scanSchedules()re-reads the first 4KB of every project's JSONL files (fs.readFileSync(jsonl, 'utf8').slice(0, 4000)) for every project folder, solely to extract each project'scwd(itsprojectPath). With many projects this is repeated disk I/O and JSON parsing every minute, even though the same mapping is already cached.Fix
db.jsalready maintains acache_metatable and exportsgetAllFolderMeta()returning aMap<folder, row>where each row carriesprojectPath. The scheduler now:folder → projectPathmap fromcache_metaonce per scan (loadFolderMetaMap()).projectPathfrom that cache first.readProjectPathFromJsonl()) only when a folder is genuinely uncached.db.jsis lazy-required inside the function so that requiringschedule-runner.jsnever forces the nativebetter-sqlite3binding to load, and the lookup is wrapped intry/catchreturning an empty map if the cache is unavailable — falling back to the original behavior.Notes
Behavior-preserving: identical
projectPathresolution (same fallback, sameif (!projectPath) continue, same schedules/triggers). Nodb.jschanges were needed — the existinggetAllFolderMeta()export is reused as-is. Syntax-checked (node --check); the test suite passes.