perf(app): poll active sessions adaptively (3s active, 30s idle)#64
Open
JeanBaptisteRenard wants to merge 1 commit into
Open
perf(app): poll active sessions adaptively (3s active, 30s idle)#64JeanBaptisteRenard wants to merge 1 commit into
JeanBaptisteRenard wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The renderer polls active PTY sessions every 3s unconditionally via
setInterval(pollActiveSessions, 3000). Each tick performs an IPC round-trip (getActiveSessions) plus a full-sidebarquerySelectorAllsweep inupdateRunningIndicators()— even when zero sessions are running. On an idle app this is steady, pointless CPU churn.Fix
Poll adaptively:
pollActiveSessions()now re-arms itself viascheduleActiveSessionsPoll(), which schedules the next tick at 3s while any PTY is running (activePtyIds.size > 0) and 30s when idle.pollActiveSessions()explicitly, so an in-renderer session start re-arms the fast cadence immediately.setIntervalnow no-ops whenlastActivityTimeis empty.Notes
Behavior-preserving: identical polling work and indicator updates while sessions run; the only change is cadence when idle. Syntax-checked (
node --check); the test suite passes.