perf(db): batch-fetch content hashes in merge and rebase loops#469
Merged
Conversation
Replace per-file fetchVersionContentHash() calls (N queries for N files) with a single batchFetchVersionContentHashes() call using ANY($1) in both the merge commit hash loop (~line 718) and the rebase replay loop (~line 874). Introduces batchFetchVersionContentHashes(ctx, tx, versionIDs) that does SELECT version_id, content_hash FROM documents WHERE version_id = ANY($1) and returns a map for O(1) lookups. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batchFetchVersionContentHashes(ctx, tx, versionIDs []string) (map[string]string, error)that issues a singleSELECT version_id::text, content_hash FROM documents WHERE version_id = ANY($1)instead of one query per fileMerge(~line 718) with a pre-fetch + map lookupRebase(~line 874) with a pre-fetch of all version IDs across all rebase groups before the outer loop, then map lookups insideThe existing
fetchVersionContentHashis kept (still used nowhere after this change, but left for potential future use — could be cleaned up separately).Test plan
go build ./...— cleango vet ./...— cleango test ./... -count=1— all packages pass;TestDockerSmokeininternal/serverfails due to a pre-existing GCP registry auth issue unrelated to this change (requiresgcloud auth login)Notes
fetchVersionContentHashis now unused and could be deleted; worth a follow-up cleanup PR.pq.Arrayhelper (already imported viagithub.com/lib/pq) handles theuuid[]conversion forANY($1)correctly.🤖 Generated with Claude Code