refactor(server): consolidate duplicate URL parsing into splitRepoPath#468
Merged
Conversation
Both parseRepoPath (handlers.go) and repoAndSubPath (middleware.go) were independently implementing the same /-/ URL parsing logic, with a comment in both files warning they must stay in sync. This change introduces splitRepoPath in a new url.go file as the single source of truth. Both functions now delegate to it, eliminating the duplication. Also adds TestSplitRepoPathConsistency to verify the two wrappers agree on repo name and endpoint for the same input paths. Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseRepoPathin handlers.go andrepoAndSubPathin middleware.go) were independently implementing the same/-/URL parsing logic, with comments in both files warning they must stay in syncsplitRepoPathin a newinternal/server/url.goas the single source of truth for parsing/repos/.../-/endpointpathssplitRepoPath, eliminating the duplication and the "keep in sync" commentTestSplitRepoPathConsistencyto verify thatparseRepoPathandrepoAndSubPathproduce the same repo name and endpoint for the same input pathsTest plan
TestSplitRepoPathConsistency— new test verifying both wrappers agreeTestRepoAndSubPath— existing test continues to pass./internal/server/...test suite passes (pre-existingTestDockerSmokefailure is unrelated — requires GCP credentials not available in this environment)go build ./...andgo vet ./...clean🤖 Generated with Claude Code