Update main branch#1214
Merged
Merged
Conversation
…s an external adjunct
…rect adjunct size calculation/persistence
Engine handles hosted adjuncts
PullRequest template
Add InlineAnnotation to the API
- Always use the native path format - Remove custom class for ExternalResource - Move adjunct route prefix from deliver channels - Test motivation further - Remove duplication from CreateInlineAnnotation
Disallow spaces that aren't a positive integer
Address PR comments, add link in RFC readme
RFC: Hosted Annotation Adjuncts `id` Property Handling
- remove InlineAnnotation - add setting for guard - return 404 for missing adjunct instead of 500 - extract helper function for setting the new id
Allow modifiying the id of a hosted annotation id
Co-authored-by: donaldgray <[email protected]>
…nted Decrement image storage for adjuncts
Without this deleting a space then recreating one with the same id can result in the old CustomerStorage record being surfaced
Refactor CreateCustomer to call new customerStorage method to create customerStorage record, rather than doing in handler. Refactor SpaceRepository: * rename PutSpace => UpsertSpace * share create logic between upsert and create
Delete CustomerStorage on space delete
Text-services ADR
JackLewis-digirati
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Merge develop into main ahead of creating new release.