Skip to content

lower array equals only if it needs code gen #14981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
WalterBright wants to merge 2 commits into from
Closed

lower array equals only if it needs code gen #14981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11140b4
lower array equals only if it needs code gen
WalterBright Mar 10, 2023
c2ba35f
Update failing tests + Fix Issue 23771
RazvanN7 May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/src/dmd/expressionsem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12370,7 +12370,8 @@ private extern (C++) final class ExpressionSemanticVisitor : Visitor
}

// lower some array comparisons to object.__equals(e1, e2)
if (needsArrayLowering || (t1.ty == Tarray && t2.ty == Tarray))
if (sc.needsCodegen() &&
(needsArrayLowering || (t1.ty == Tarray && t2.ty == Tarray)))
{
//printf("Lowering to __equals %s %s\n", exp.e1.toChars(), exp.e2.toChars());

Expand Down
15 changes: 7 additions & 8 deletions compiler/test/fail_compilation/diag7420.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,16 @@
/*
TEST_OUTPUT:
---
fail_compilation/diag7420.d(21): Error: static variable `x` cannot be read at compile time
fail_compilation/diag7420.d(21): while evaluating: `static assert(x < 4)`
fail_compilation/diag7420.d(20): Error: static variable `x` cannot be read at compile time
fail_compilation/diag7420.d(20): while evaluating: `static assert(x < 4)`
fail_compilation/diag7420.d(21): Error: static variable `y` cannot be read at compile time
fail_compilation/diag7420.d(21): while evaluating: `static assert(y == "abc")`
fail_compilation/diag7420.d(22): Error: static variable `y` cannot be read at compile time
fail_compilation/diag7420.d(22): called from here: `__equals(y, "abc")`
fail_compilation/diag7420.d(22): while evaluating: `static assert(y == "abc")`
fail_compilation/diag7420.d(22): while evaluating: `static assert(cast(ubyte[])y != null)`
fail_compilation/diag7420.d(23): Error: static variable `y` cannot be read at compile time
fail_compilation/diag7420.d(23): while evaluating: `static assert(cast(ubyte[])y != null)`
fail_compilation/diag7420.d(23): while evaluating: `static assert(cast(int)y[0] == 1)`
fail_compilation/diag7420.d(24): Error: static variable `y` cannot be read at compile time
fail_compilation/diag7420.d(24): while evaluating: `static assert(cast(int)y[0] == 1)`
fail_compilation/diag7420.d(25): Error: static variable `y` cannot be read at compile time
fail_compilation/diag7420.d(25): while evaluating: `static assert(y[0..1].length == 1u)`
fail_compilation/diag7420.d(24): while evaluating: `static assert(y[0..1].length == 1u)`
---
*/

Expand Down
2 changes: 1 addition & 1 deletion compiler/test/fail_compilation/ice19762.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
/*
TEST_OUTPUT:
---
fail_compilation/ice19762.d(13): Error: struct `ice19762.X` had semantic errors when compiling
fail_compilation/ice19762.d(16): Error: undefined identifier `Err`, did you mean variable `err`?
---
*/

Expand Down