Use pnpm#176
Merged
Merged
Conversation
knuton
force-pushed
the
use-pnpm
branch
2 times, most recently
from
dd16099 to
10efa07
Compare
dividat-jgu
reviewed
Jun 18, 2026
dividat-jgu
left a comment
dividat-jgu
left a comment
Contributor
There was a problem hiding this comment.
Code change is looking good. This needs rebasing. I’ll test it out once it’s rebased.
When splitting nixpkgs dependencies into the "main" version for general builds (24.11) and the forward version for macOS builds (25.05), the motivation was that 24.11 did not work for macOS, but everything else should stay in line with the driver's main environment PlayOS, which was pinned to 24.11 at the time. PlayOS has since been upgraded to 25.11 and may be further upgraded to 26.05 before the next release. Either way, unifying to a single 26.05 channel nixpkgs version from does not require significant changes to the build definitions relative to 24.11. So we should not expect surprises even when building in 25.11 in the context of PlayOS. Moving everything to 26.05 unifies macOS and other cross-build targets again, and allows us to bring in modern versions of developer tools. In particular, we want to replace npm with pnpm v11.
This reference now throws with a warning, it seems advised to delete it without replacement: > You may see references to darwin.apple_sdk.frameworks. This is the > legacy SDK pattern, and it is being phased out. All packages in > darwin.apple_sdk, darwin.apple_sdk_11_0, and darwin.apple_sdk_12_3 have > been removed. If your derivation references them, you should delete > those references, as the default SDK should be enough to build your > package. https://nixos.org/manual/nixpkgs/stable/#sec-darwin-legacy-frameworks
I could not find this to be a known issue, but `pnpm install` seems to
fail on GitHub's macOS CI runners with pnpm v11.4.0.
(node:6000) Warning: File descriptor 44 closed but not opened in unmanaged mode
(node:6000) Warning: File descriptor 44 opened in unmanaged mode twice
(node:6000) Warning: File descriptor 44 closed but not opened in unmanaged mode
(node:6000) Warning: File descriptor 44 opened in unmanaged mode twice
(node:6000) Warning: File descriptor 44 closed but not opened in unmanaged mode
Progress: resolved 114, reused 0, downloaded 114, added 114, done
dependencies:
+ bonjour 3.5.0
+ chai 4.3.4
+ mocha 10.8.2
+ ws 8.20.1
devDependencies:
+ binary-split 1.0.5
+ commander 12.1.0
make: *** [Makefile:37: test] Killed: 9
Error: Process completed with exit code 2.
https://github.com/dividat/driver/actions/runs/27065072565/job/79888185694
Tried bumping NodeJS to current LTS. It didn't help the killed pnpm
process, but it's a good idea to use it anyway.
Maintainer is strategically refusing to publish a `4.0.x` patch release with fixed provenance to get library users to update. The latest stable mocha release (v11) still relies on `4.0.x`[^1], major version v12 should bump to chokidar 5.0.0, no release date announced[^2]. [^1]: https://github.com/mochajs/mocha/blob/v11.7.7/package.json [^2]: mochajs/mocha#5357
This is just
pnpm import
rm package-lock.json
Member
Author
|
Rebased |
Contributor
|
OK running Senso driver, but I’m getting an error running the replayer for Flex devices: $ node tools/replay-flex --device v6 rec/flex/v6/zero.v6.ws.dat
…
Error: Cannot find module 'debug'
… |
dividat-jgu
added
details needed
Used in flex replay tool implementation, previously brought in as a transitive dependency, but transitive dependency can no longer be required with pnpm's isolated installs.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
knuton
added
dependencies
Member
Author
|
Sorry for missing this, needed to make a dependency explicit: b7eece6 |
Contributor
|
I can now replay a Flex. 👌 |
dividat-jgu
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it has before, pnpm proves to be a fragile beast, failing with an issue I did not find documented in pnpm issue tracker on macOS CI runners, when performing the advanced operation of
pnpm install(Fix pnpm on macOS CI runners). Still the better bullet to bite compared with npm, unfortunately.Checklist
[ ] Rebase and merge after Bump npm dependencies (npm audit) #177