Skip to content

task-observer: new docs/ai/review from 2026-07-20 - #76

Open
divad12 wants to merge 1 commit into
masterfrom
task-observer/review-2026-07-20
Open

task-observer: new docs/ai/review from 2026-07-20#76
divad12 wants to merge 1 commit into
masterfrom
task-observer/review-2026-07-20

Conversation

@divad12

@divad12 divad12 commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Target

new-global-doc: docs/ai/review.md

Observations addressed

  • Observation 17 (journology/log.md): Review and bug learning need clear global/local layers → changed: created docs/ai/review.md with reusable review contracts covering scope detection (use declared integration branch, not hardcoded main), finding admissibility (de-scoped features are inadmissible), bug-fix routing (structured learning with root cause, principle, anti-pattern, and enforcement candidate), and the global/project layering contract.

Note: AGENTS.md routing table update (review.md row) was skipped because the edit was rejected.


Generated by Claude Code

Extracts reusable review contracts into a global reference doc:
- Scope detection: use project's declared integration branch, not hardcoded main
- Finding admissibility: de-scoped features are inadmissible findings
- Bug-fix routing: structured learning with root cause, principle,
  anti-pattern, and enforcement candidate per bug class
- Layering: global contracts here, project deltas in <project>/docs/ai/review.md

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 162127b89b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/ai/review.md

## Contract

- Orchestration skills (`/deep-review`, `/fly` gates) say how to run the workflow. This doc holds the reusable contracts for what to look for and how to route findings.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire review.md into review activation

This new global contract is not loaded by normal review workflows: .claude/AGENTS.md's adaptive-docs table still routes only git/writing/ask-intern/learning, and the only existing review.md routing I found is preflight's generated task pre-reading, while /deep-review still hard-codes main for branch scope. As a result, repos whose integration branch is master/m3 will still get the noisy or wrong review base this doc is meant to prevent unless the review skills or root routing table are updated to read it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants