Skip to content

Ditto scan#141

Merged
joustrich merged 7 commits into
masterfrom
ptd-base
Jun 16, 2026
Merged

Ditto scan#141
joustrich merged 7 commits into
masterfrom
ptd-base

Conversation

@joustrich

@joustrich joustrich commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR introduces the scan command into the Ditto CLI. The scan command takes a single input, a path, and scans all files at that path to identify all user-facing text. The user-facing text candidates are then fed into Ditto where they can be turned into Ditto components from within the Ditto web application.

Context

This is a base branch, so there have already been a number of PRs/reviews to get to this point. Here are the existing PRs that have been reviewed:

Only the latest commit for some final cleanup is new and would be good to get reviewed more thoroughly.

Test Plan

Testing successfully completed in via:

  • Quick regression test of pull
  • Run scan on a repository with user facing text (matrix-poll is a good example with both variants and plurals). You should be able to follow the link to complete the flow in the web app.

joustrich added 4 commits June 2, 2026 12:43
* Implement baseline 'scan' command

* Add types output

* Add readme docs for new 'scan' command
* Get rid of remaining LLM integration and replace i18n detection with a heuristic approach. Also wires up the public API integration.
@joustrich joustrich requested a review from asnewman June 15, 2026 19:26
@joustrich joustrich requested a review from jholiga June 15, 2026 19:26
@joustrich joustrich marked this pull request as ready for review June 15, 2026 19:26
@joustrich joustrich removed the request for review from asnewman June 15, 2026 19:58

@jholiga jholiga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments. Everything else looks good! Approving

Comment thread lib/src/formatters/mixins/javascriptCodegenMixin.ts
Comment thread lib/src/utils/DittoError.ts Outdated
Comment thread lib/src/services/apiToken/promptForApiToken.ts
@joustrich joustrich merged commit bdd0f6f into master Jun 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants