Resolving Vulnerability of Go Test FIle#3
Merged
Merged
Conversation
…workflows, streamlining the workflows to only respond to pull requests for relevant paths.
…g cloud.google.com/go/compute/metadata v0.3.0 and various golang.org/x packages, improving compatibility and security.
…um for improved security and compatibility.
There was a problem hiding this comment.
Pull request overview
This PR updates several Go indirect dependencies (including security-sensitive packages) and modifies mobile SDK CI workflows for Android, iOS, Flutter, and React Native.
Changes:
- Bumped versions of
cloud.google.com/go/compute/metadata,github.com/golang-jwt/jwt/v4, and multiplegolang.org/x/*libraries ingo.mod/go.sum, and removed unused/older sums. - Removed the
pushtrigger and branch filters from the iOS, Flutter, and React Native workflows, leaving them to run only onpull_requestevents for specific paths. - Simplified the Android workflow triggers by removing branch and path filters from the
pushevent while retaining path filters forpull_request.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
go.sum |
Aligns checksum file with updated indirect dependency versions and drops unused module checksums. |
go.mod |
Updates indirect dependency versions (e.g., cloud.google.com/go/compute/metadata, github.com/golang-jwt/jwt/v4, golang.org/x/*) and removes unused google.golang.org/appengine v1 entry. |
.github/workflows/react-native.yml |
Limits CI to PRs touching React Native files; however, the release job is now unreachable because it still requires a push event that no longer triggers this workflow. |
.github/workflows/ios.yml |
Limits CI to PRs touching iOS files; similarly, the release job can no longer run due to the missing push trigger while still checking for github.event_name == 'push'. |
.github/workflows/flutter.yml |
Limits CI to PRs touching Flutter files; the release job is likewise disabled because it depends on push events that no longer start this workflow. |
.github/workflows/android.yml |
Keeps Android CI and release functional on push and PRs, but now triggers on every push to any branch, relying on in-job change detection to short-circuit non-Android changes. |
Comments suppressed due to low confidence (3)
.github/workflows/ios.yml:8
- The
releasejob is now unreachable because this workflow no longer triggers onpushevents, but the job condition still requiresgithub.event_name == 'push'. As a result, iOS releases will never run; to restore release behavior you need to either reintroduce apushtrigger or adjust theifcondition to match the events that can start this workflow.
on:
pull_request:
paths:
- 'ios/**'
- '.github/workflows/ios.yml'
.github/workflows/flutter.yml:8
- The
releasejob is now unreachable because this workflow no longer triggers onpushevents, while the jobifstill requiresgithub.event_name == 'push'. This means Flutter releases will never run; consider re-adding apushtrigger or updating the condition so the job can execute under the intended events.
on:
pull_request:
paths:
- 'flutter/**'
- '.github/workflows/flutter.yml'
.github/workflows/react-native.yml:8
- With the removal of the
pushtrigger, thereleasejob is now impossible to run because it is conditioned ongithub.event_name == 'push'. This effectively disables React Native package releases; to fix this, either restore apushtrigger or relax the job condition so it can run on an event that still triggers this workflow (e.g., a specificworkflow_dispatchorpull_requestmerge path).
on:
pull_request:
paths:
- 'react-native/**'
- '.github/workflows/react-native.yml'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.