Skip to content

Resolving Vulnerability of Go Test FIle#3

Merged
igorgsduarte merged 3 commits into
mainfrom
dev
Jan 27, 2026
Merged

Resolving Vulnerability of Go Test FIle#3
igorgsduarte merged 3 commits into
mainfrom
dev

Conversation

@igorgsduarte

Copy link
Copy Markdown
Contributor

No description provided.

…workflows, streamlining the workflows to only respond to pull requests for relevant paths.
…g cloud.google.com/go/compute/metadata v0.3.0 and various golang.org/x packages, improving compatibility and security.
@igorgsduarte igorgsduarte self-assigned this Jan 27, 2026
Copilot AI review requested due to automatic review settings January 27, 2026 21:05
@igorgsduarte
igorgsduarte merged commit 832fe36 into main Jan 27, 2026
3 of 6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates several Go indirect dependencies (including security-sensitive packages) and modifies mobile SDK CI workflows for Android, iOS, Flutter, and React Native.

Changes:

  • Bumped versions of cloud.google.com/go/compute/metadata, github.com/golang-jwt/jwt/v4, and multiple golang.org/x/* libraries in go.mod/go.sum, and removed unused/older sums.
  • Removed the push trigger and branch filters from the iOS, Flutter, and React Native workflows, leaving them to run only on pull_request events for specific paths.
  • Simplified the Android workflow triggers by removing branch and path filters from the push event while retaining path filters for pull_request.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.sum Aligns checksum file with updated indirect dependency versions and drops unused module checksums.
go.mod Updates indirect dependency versions (e.g., cloud.google.com/go/compute/metadata, github.com/golang-jwt/jwt/v4, golang.org/x/*) and removes unused google.golang.org/appengine v1 entry.
.github/workflows/react-native.yml Limits CI to PRs touching React Native files; however, the release job is now unreachable because it still requires a push event that no longer triggers this workflow.
.github/workflows/ios.yml Limits CI to PRs touching iOS files; similarly, the release job can no longer run due to the missing push trigger while still checking for github.event_name == 'push'.
.github/workflows/flutter.yml Limits CI to PRs touching Flutter files; the release job is likewise disabled because it depends on push events that no longer start this workflow.
.github/workflows/android.yml Keeps Android CI and release functional on push and PRs, but now triggers on every push to any branch, relying on in-job change detection to short-circuit non-Android changes.
Comments suppressed due to low confidence (3)

.github/workflows/ios.yml:8

  • The release job is now unreachable because this workflow no longer triggers on push events, but the job condition still requires github.event_name == 'push'. As a result, iOS releases will never run; to restore release behavior you need to either reintroduce a push trigger or adjust the if condition to match the events that can start this workflow.
on:
  pull_request:
    paths:
      - 'ios/**'
      - '.github/workflows/ios.yml'

.github/workflows/flutter.yml:8

  • The release job is now unreachable because this workflow no longer triggers on push events, while the job if still requires github.event_name == 'push'. This means Flutter releases will never run; consider re-adding a push trigger or updating the condition so the job can execute under the intended events.
on:
  pull_request:
    paths:
      - 'flutter/**'
      - '.github/workflows/flutter.yml'

.github/workflows/react-native.yml:8

  • With the removal of the push trigger, the release job is now impossible to run because it is conditioned on github.event_name == 'push'. This effectively disables React Native package releases; to fix this, either restore a push trigger or relax the job condition so it can run on an event that still triggers this workflow (e.g., a specific workflow_dispatch or pull_request merge path).
on:
  pull_request:
    paths:
      - 'react-native/**'
      - '.github/workflows/react-native.yml'


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants