Kazirygl patch 1 - edits to discosscan.py#19
Open
kazirygl wants to merge 14 commits into
Open
Conversation
These changes calculate the velocity axis without the assumption that it is perfectly centered on VLSR.
Author
|
The number of commits reflects that it was VERY hard to find the wrong whitespaces it kept complaining about... and the X&(&%^&( editor of github is useless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Sergio,
I've made the edits in discosscan.py (the Xarcos version) to create a correct velocity axis in the class file, not depending any more on the central frequency. At the moment it uses RADIO definition. Please have a look at the branch kazirygl-patch-1 and see if it makes sense to you.
Cheers
Kazi