Skip to content
This repository was archived by the owner on Jul 12, 2023. It is now read-only.

Fix music bot example#237

Open
conr wants to merge 4 commits into
discordjs:mainfrom
conr:fix-music-example
Open

Fix music bot example#237
conr wants to merge 4 commits into
discordjs:mainfrom
conr:fix-music-example

Conversation

@conr

@conr conr commented Nov 26, 2021

Copy link
Copy Markdown

Fixes for a bunch of Typescript errors in the music bot example.

"extends": "../../tsconfig.json",
"compilerOptions": {
"baseUrl": ".",
"outDir": "dist",

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already included in the parent tsconfig.json https://github.com/discordjs/voice/blob/main/tsconfig.json#L29

Comment on lines +51 to +54
output: '-',
quiet: true,
format: 'bestaudio[ext=webm+acodec=opus+asr=48000]/bestaudio',
limitRate: '100K',

@conr conr Nov 26, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types for the flags were added to youtube-dl-exec in this commit.

@almeidx

almeidx commented Nov 26, 2021

Copy link
Copy Markdown
Member

Should probably bump youtube-dl-exec to the latest version.
And while you're at it, why not bump typescript to the latest version as well instead of 4.4?

@conr

conr commented Nov 26, 2021

Copy link
Copy Markdown
Author

@almeidx Good call. Updated 👍🏻

@conr

conr commented Dec 10, 2021

Copy link
Copy Markdown
Author

@iCrawl Is this good to go?

@codecov

codecov Bot commented Dec 12, 2021

Copy link
Copy Markdown

Codecov Report

Merging #237 (fb1aa78) into main (3dabc30) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files          21       21           
  Lines         911      911           
  Branches      227      221    -6     
=======================================
  Hits          671      671           
  Misses        238      238           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dabc30...fb1aa78. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants