refactor(config): distinguish model names from objects#320
refactor(config): distinguish model names from objects#320manzuoni-astera wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
marcuscollins
left a comment
There was a problem hiding this comment.
Do we also need to update the readme? I guess we can still use --model, so maybe not.
|
Addressed the review in
Focused CLI/config/metadata tests pass ( |
Summary
model_nameacross guidance, grid-search jobs, and job results--modelCLI flag with an explicit argparse destinationmodelparameters unchanged because those hold loaded model objectsImplements #289. This PR is intentionally stacked on #300 because it updates the Protpardelle-integrated guidance files; #289 should remain open until the stack reaches
main.The README CLI examples remain valid because
--modelis unchanged.Validation
pytest tests/cli/test_guidance_cli.py tests/utils/test_guidance_script_arguments.py tests/utils/test_guidance_script_utils.py -q(110 passed)ty checkpassesruff checkandruff format --checkon touched Python filesgit diff --check