fix(cli): handle IS NULL / IS NOT NULL in FilterCommand switch#129
Merged
Conversation
The sealed RowFilter gained IsNull/IsNotNull arms; FilterCommand's row-level toRowPredicate switch was not updated, breaking compilation on main. Add both arms: a row is null only when the column decodes to a MaskedArray whose validity bit is unset (unmasked arrays are null-free). Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores main: the sealed
RowFiltergainedIsNull/IsNotNull(PR #128) butFilterCommand.toRowPredicate's row-level switch was not updated, sovortex-clifaileddefault-compile(switch not exhaustive).Adds both arms. A row is null only when its column decodes to a
MaskedArraywith the validity bit unset; an unmasked array is null-free, so every row is non-null.🤖 Generated with Claude Code